Additional elixir 1.15 compatibility #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to try this out in one of our apps for testing, hopefully today or tomorrow. |
|
@tpitale Sounds good. If there are additional sasl messages that need to be silenced, it would be easy to add them to I originally thought about silencing all |
|
This has been running great. I'm going to get one other person to take a look and then we can merge and release! Thank you, again, so much @tmaszk |
tpitale
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on to PR #421 and should completely address Issue #419
The purpose of the new
NewRelic.ErrorLoggermodule is to prevent Logger from displaying the MANY status messages caused by enablinghandle_sasl_reports.I don't like requiring the user update their
:loggerconfig to allow the agent to capture errors, but can't think of another way to do it.This PR also has the nice side effect of not showing the error messages in the console when running
mix test, because it no longer logs errors to the console during the unit tests.@tpitale FYI. This PR plus #424, I think it would make a nice update for Elixir users.